Simplify handling of sockaddr information lookup #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a custom deleter, we must take care to also delete the pointer managed by the unique_ptr.
Rather than gethostbyname and then manually constructing a struct sockaddr_in, make the lookup IPv6-agnostic by using getaddrinfo directly.
Rather than heap-allocating the endpoint parameters, as well as the addrinfo, stack allocate the endpoint parameters and use a unique_ptr managed heap allocation for addrinfo. This is safe because endpoint and listener creation copies the addrinfo data upon initialisation.
Now that this just returns an addrinfo struct, the previous name was misleading.
|
Thanks, done! |
|
I just squashed the remaining few places where param structs were separated from initialisation. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate away from using
gethostbyname(deprecated) togetaddrinfo. As a consequence, we can refactor some memory management and handle allocation lifetime with aunique_ptr.Although this doesn't introduce a class for managing sockaddr objects, it does make the lifetime management transparent enough that this closes #8.