Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain copy of header for AM send requests #349

Merged

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Jan 16, 2025

Retain a copy of headers for AM send requests as workaround for possible UCX bug openucx/ucx#10424 .

Unfortunately, reproducing this is not straightforward and it wasn't observed in a stack that can be made into UCXX tests currently, so testing this is not possible at the moment.

@pentschev pentschev added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 16, 2025
@pentschev pentschev requested a review from a team as a code owner January 16, 2025 11:24
Retain a copy of headers for AM send requests as workaround for possible
UCX bug openucx/ucx#10424 .
@pentschev pentschev force-pushed the am-header-copy-bug-workaround branch from b5dd27b to 8940ce6 Compare January 16, 2025 11:27
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pentschev
Copy link
Member Author

Thanks @madsbk !

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 13bd420 into rapidsai:branch-0.42 Jan 16, 2025
61 checks passed
@pentschev pentschev deleted the am-header-copy-bug-workaround branch January 17, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants