Separate libucxx build and ucxx build #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
improvement
|
The import test for ucxx/conda/recipes/ucxx/meta.yaml Lines 258 to 259 in 95f4eda |
pentschev
requested changes
Aug 1, 2024
|
Thanks for the review @pentschev. This PR is still very much a work in progress. I'll address whatever portions of your review are still relevant once I've actually got it working. |
KyleFromNVIDIA
changed the title
bdice
reviewed
Aug 2, 2024
pentschev
reviewed
Aug 5, 2024
pentschev
approved these changes
Aug 6, 2024
jameslamb
approved these changes
Aug 6, 2024
|
/merge |
vyasr
added a commit
to rapidsai/devcontainers
that referenced
this pull request
Dec 2, 2024
This PR fixes a number of issues in the manifest: - cudf's dependency on rmm was accidentally removed in #221. Since rmm is header-only I guess nobody noticed the issue since it doesn't increase build times and only shows up if you attempt to make local changes to rmm and test them in cudf. - UCXX_ENABLE_PYTHON was removed in rapidsai/ucxx#257 - cuml depends on cuvs as of rapidsai/cuml#6085 - cugraph does not depend on cugraph-ops as of rapidsai/cugraph#4744 - Many packages were relying on transitively getting rmm or raft as dependencies, which causes problems when the intermediate dependency is removed. Extra `-D<package_name>_ROOT` variables in the CMake configure don't cause any problems so I made everything explicit. --------- Co-authored-by: Paul Taylor <[email protected]> Co-authored-by: Bradley Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than building
libucxx_python.soin thelibucxxbuild, and transferring it to theucxxpackage, build it in theucxxbuild.Nothing other than the Python wheel is currently using
ucxx::python, so stop exporting it and installing the headers as well.