Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid --find-links. #235

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Avoid --find-links. #235

merged 2 commits into from
Jun 10, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jun 5, 2024

Avoid pip --find-links which can fail to install and fall back to older wheels. See rapidsai/build-planning#69 for more information.

@bdice bdice requested a review from a team as a code owner June 5, 2024 21:40
@bdice bdice added non-breaking Introduces a non-breaking change bug Something isn't working labels Jun 5, 2024
@pentschev pentschev requested a review from a team as a code owner June 10, 2024 07:57
@pentschev pentschev requested a review from raydouglass June 10, 2024 07:57
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdice

@bdice
Copy link
Contributor Author

bdice commented Jun 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit deb7d07 into rapidsai:branch-0.39 Jun 10, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants