-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml #174
Conversation
It looks like some conflicts crept in here. Maybe these files need to be regenerated with |
Have resolved conflicts with PR ( #164 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are moving to rapids-dask-dependency
in this PR, think we should update the Conda recipes as well. In particular am noticing these lines here
ucxx/conda/recipes/ucxx/meta.yaml
Lines 274 to 275 in 2249bed
- dask >=2023.9.2 | |
- distributed >=2023.9.2 |
@jakirkham I just did that in 20a86a4 I don't see any other uses of |
whoops that needs to be a RAPIDS version not UCX's version
Will fix that momentarily. |
Co-authored-by: jakirkham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks James! 🙏
I noticed a small issue, |
Totally fine, thanks for that! I hadn't noticed it. |
Thanks Bradley! 🙏 Had missed that |
Co-authored-by: jakirkham <[email protected]>
/merge |
Thanks all! 🙏 |
Contributes to rapidsai/build-planning#13.
Updates
update-version.sh
to correctly handle RAPIDS dependencies likecudf-cu12==24.2.*
.This also pulls in some dependency refactoring originally added in #161, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).
How I tested this
The portability of this updated
sed
command was tested here: rapidsai/cudf#14825 (comment).In this repo, I ran the following:
Confirmed that that first
git diff
changed all the things I expected, and that second one showed 0 changes.