Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some minor clang-tidy issues #152

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Fix some minor clang-tidy issues #152

merged 7 commits into from
Jan 9, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jan 8, 2024

@wence- wence- requested review from a team as code owners January 8, 2024 15:59
wence-
wence- commented Jan 8, 2024
View reviewed changes
cpp/src/worker.cpp Show resolved Hide resolved
cpp/src/utils/sockaddr.cpp Show resolved Hide resolved
cpp/src/request_tag_multi.cpp Show resolved Hide resolved
pentschev
pentschev approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left only a couple minor comments but otherwise good to go. Thanks @wence- !

cpp/src/worker.cpp Show resolved Hide resolved
cpp/src/request_tag_multi.cpp Outdated Show resolved Hide resolved
@pentschev
Copy link
Member

Seems that CI tests are hanging, I can't immediately see what would cause this and it doesn't seem to be a general CI issue since other PRs that were opened today (#153 and #154) are not experiencing the same issue.

@wence-
Copy link
Contributor Author

wence- commented Jan 9, 2024

I think this is now good, but wants to wait for #153

@pentschev
Copy link
Member

I think this is now good, but wants to wait for #153

Not sure if they're the same issue but we can merge that and rerun to have a more "up-to-date" CI output here.

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 2a19c57 into rapidsai:branch-0.36 Jan 9, 2024
23 checks passed
@pentschev
Copy link
Member

Thanks for fixing this @wence- !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: 'exchange' is not a member of 'std' when trying to build with development environments
2 participants
@wence- @pentschev