Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rapids-build-backend #9

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jun 3, 2024

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/build-planning#69

Proposes:

  • introducing rapids-build-backend as this project's build backend, to reduce the complexity of various CI/build scripts
  • using pip install ./dist/*.whl instead of pip install --find-links ./dist in CI, to reduce the risk of the types of bugs described in Remove uses of 'pip --find-links' in CI build-planning#69

Notes for reviewers

This project doesn't currently have a dependencies.yaml. rapids-build-backend does technically support that (rapidsai/rapids-build-backend#33), so I chose not to introduce a dependencies.yaml file here just for that purpose.

@jameslamb jameslamb added DO NOT MERGE Hold off on merging; see PR for details improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 3, 2024
@jameslamb jameslamb changed the title WIP: use rapids-build-backend use rapids-build-backend Jun 3, 2024
@jameslamb jameslamb removed the DO NOT MERGE Hold off on merging; see PR for details label Jun 3, 2024
@jameslamb jameslamb marked this pull request as ready for review June 3, 2024 20:58
@jameslamb jameslamb requested a review from a team as a code owner June 3, 2024 20:58
python/libucx/pyproject.toml Show resolved Hide resolved
@jameslamb jameslamb merged commit d49e708 into rapidsai:main Jun 3, 2024
13 checks passed
@jameslamb jameslamb deleted the rapids-build-backend branch June 3, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants