Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish v1.14.1.post1 #6

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented May 10, 2024

Follow-up to #5.

Proposes publishing a 1.14.1.post1 version, identical to version 1.14.1 except that load_library() will no longer raise exceptions in non-GPU environments.

Notes for Reviewers

Just putting this up to get in the CI run. Should probably wait to merge it until testing on rapidsai/ucx-py#1041 is done.

@jameslamb jameslamb added bug Something isn't working non-breaking Introduces a non-breaking change labels May 10, 2024
@pentschev
Copy link
Member

No opposition from me if there's a specific use case, but notice that we don't support 1.14.x anymore, see https://github.com/rapidsai/ucx-py/blob/c1c34669d5b295c0d5f260e3c38de1dfe00efb32/dependencies.yaml#L118-L120 and https://github.com/rapidsai/ucx-py/blob/c1c34669d5b295c0d5f260e3c38de1dfe00efb32/conda/recipes/ucx-py/meta.yaml#L38, the same is true for UCXX.

@jameslamb
Copy link
Member Author

Oh ok, thank you!

I'll let @vyasr comment, but I think we're looking to patch every libucx we've published from this repo (v1.14, v1.15, v1.16) just for completeness. So that, for example, rolling back to v1.14.0 or integrating some other project that requires v1.14.0 will still be able to benefit from these wheels.

If you're curious, you can see the versions that have been published at https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/libucx-cu12/

image

Which makes me realize... this should really be 1.14.1.post1, not 1.14.0.post1. Just pushed a commit with that change: f15aef5

@jameslamb jameslamb changed the title publish v1.14.0.post1 publish v1.14.1.post1 May 10, 2024
@jameslamb jameslamb marked this pull request as ready for review May 10, 2024 16:22
@jameslamb jameslamb requested a review from a team as a code owner May 10, 2024 16:22
@vyasr
Copy link
Contributor

vyasr commented May 10, 2024

Yup James is right, the goal here is to supersede the first round of wheels (even for versions of libucx that RAPIDS isn't using) so that we don't publish broken libraries.

@vyasr vyasr merged commit b79e73c into rapidsai:main May 10, 2024
12 checks passed
@jameslamb jameslamb mentioned this pull request May 10, 2024
vyasr pushed a commit that referenced this pull request May 10, 2024
Follow-up to #5.
Similar to #6.

Proposes publishing a `1.16.0.post1` version, identical to version
`1.16.0` except that `load_library()` will no longer raise exceptions in
non-GPU environments.

## Notes for Reviewers

Checked
https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/libucx-cu12/ to
confirm that it's exactly `1.16.0` that we want to do a post-release
for.
@jameslamb jameslamb deleted the update/v1.14.0.post branch May 10, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants