Test get_buffer_data and get_buffer_nbytes
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide some initial testing of the buffer utility functions with Python builtin types. This provides us something pretty useful that we can run through without having to worry about any dependencies to start with.
jakirkham
force-pushed
the
test_libs_utils
branch
5 times, most recently
from
54fcb02 to
06bbdfc
Compare
Include some tests using NumPy and CuPy arrays. Check that pointers are what we expect them to be. Also check that `nbytes` is computed correctly.
jakirkham
force-pushed
the
test_libs_utils
branch
from
06bbdfc to
2087d65
Compare
pentschev
reviewed
Jun 16, 2020
There was a problem hiding this comment.
I have a couple of minor questions only, otherwise it looks good. Also, do these tests allow us to check for the issue from #546 (comment) ?
| arr = xp.ndarray(shape, dtype, data.data, strides=strides) | ||
| iface = getattr(arr, iface_prop) | ||
|
|
||
| return xp, arr, iface |
There was a problem hiding this comment.
Seems like xp isn't currently used for anything. Just wanted to check this is intentional.
There was a problem hiding this comment.
Yeah I wasn't sure if we would need it or not. So left in the option. We could drop it if you prefer.
There was a problem hiding this comment.
No worries, just wanted to confirm.
|
LGTM, thanks @jakirkham . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for PR ( #546 )
Adds some tests for the utility functions
get_buffer_dataandget_buffer_nbytesusing both Python builtin objects and NumPy/CuPy arrays. Should exercise both thememoryviewcase as well as the__array_interface__/__cuda_array_interface__case.