Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serialization code in benchmarks #1098

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Update serialization code in benchmarks #1098

merged 6 commits into from
Dec 11, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Dec 11, 2024 •
edited
Loading

@galipremsagar galipremsagar requested a review from a team as a code owner December 11, 2024 16:48
@galipremsagar galipremsagar added bug Something isn't working non-breaking labels Dec 11, 2024
quasiben
quasiben approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galipremsagar

@quasiben
Copy link
Member

/merge

@jakirkham
Copy link
Member

Thanks Prem and Ben! 🙏

Would have suggested the exact same change 😄

jakirkham
jakirkham requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Prem! 🙏

Looks like 0.41 was just released ( #1095 ). Do we want to move this to 0.42?

Requesting changes to avoid accidental merge while discussing

@galipremsagar galipremsagar changed the base branch from branch-0.41 to branch-0.42 December 11, 2024 19:38
@galipremsagar
Copy link
Contributor Author

Thanks Prem! 🙏

Looks like 0.41 was just released ( #1095 ). Do we want to move this to 0.42?

Requesting changes to avoid accidental merge while discussing

Moved to 0.42.

@rapids-bot rapids-bot bot merged commit 9efacc6 into rapidsai:branch-0.42 Dec 11, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@quasiben quasiben quasiben approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @quasiben @jakirkham