Sync some changes from KvikIO's Array
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
enhancement
pentschev
reviewed
Sep 30, 2024
wence-
reviewed
Oct 1, 2024
pentschev
reviewed
Oct 1, 2024
Co-authored-by: Peter Andreas Entschev <[email protected]>
pentschev
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
LGTM in spite of @wence-'s comment, that can probably be addressed in KvikIO first and then again incorporated here but it's probably a good idea to let Lawrence voice his (dis-)approval of that too. Thanks @jakirkham .
|
Any more thoughts on this one? 🙂 |
|
Not from me, I think we can leave it open another 24h, if there are no further comments until then we should merge it. |
wence-
approved these changes
Oct 16, 2024
|
/merge |
|
Thank you both! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in a few changes from KvikIO's
Array. Namely...asarrayfor easy conversion toArray(no-op if already anArray)