Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch-0.39 into branch-0.40 #1058

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

jameslamb
Copy link
Member

Getting the changes from #1057 (which targeted branch-0.39) onto branch-0.40.

Followed the procedure described at https://docs.rapids.ai/maintainers/forward-merger

Notes for Reviewers

This should be non-squash admin-merged.

Contributes to rapidsai/build-planning#31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. `cudf` depending on `rmm`, not `rmm-cu12`.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in `dependencies.yaml`.

For more details, see:
* rapidsai/build-planning#31 (comment)
* rapidsai/cudf#16183

## Notes for Reviewers

### Why target 24.08?

This is targeting 24.08 because:

1. it should be very low-risk
2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#1057
@jameslamb jameslamb requested review from a team as code owners July 25, 2024 15:18
@jameslamb jameslamb requested a review from bdice July 25, 2024 15:18
@AyodeAwe AyodeAwe merged commit eaf4e91 into rapidsai:branch-0.40 Jul 25, 2024
31 checks passed
@jameslamb jameslamb deleted the branch-0.40-merge-0.39 branch July 25, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants