Pin to pytest==7.*
#1020
Merged
Pin to pytest==7.*
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest 8 introduced breaking changes that `pytest-asyncio` is still in the process of resolving. See pytest-dev/pytest-asyncio#763. This pin should also be done directly by `pytest-asyncio>=0.23.4`, but that version is still not available in conda-forge.
charlesbluca
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Thanks @pentschev! Looks like the issue you linked is closed but progress on the hotfix is being tracked in pytest-dev/pytest-asyncio#737.
Also worth noting that it looks like the hotfix is actually released now, and we're just waiting on the conda-forge release PR to get merged:
|
Yup, I saw the conda-forge PR but while it isn't merged we can't count on it, so best to just go ahead and pin it ourselves in the meantime. Thanks @charlesbluca ! |
|
/merge |
raydouglass
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest 8 introduced breaking changes that
pytest-asynciois still in the process of resolving. Seepytest-dev/pytest-asyncio#763. This pin should also be done directly by
pytest-asyncio>=0.23.4, but that version is still not available in conda-forge.Backport of #1019 .