Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to skip uploading conda packages #33

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

ajschmidt8
Copy link
Member

This PR adds a new input, skip_upload_pkgs, to the conda-upload-packages.yaml workflow.

The value of this input is passed as an environment variable to the rapids-upload-to-anaconda script.

With the PR below merged, this will allow repositories to specify a space-delimited list of conda package names that should not be uploaded to Anaconda.org.

It can be used like this:

upload-conda:
    uses: rapidsai/shared-action-workflows/.github/workflows/conda-upload-packages.yaml@main
    with:
      skip_upload_pkgs: pkg1 pkg2 pkg3

# or with YAML multi-line features
upload-conda:
    uses: rapidsai/shared-action-workflows/.github/workflows/conda-upload-packages.yaml@main
    with:
      skip_upload_pkgs: >-
        pkg1
        pkg2
        pkg3

This PR adds a new input, `skip_upload_pkgs`, to the `conda-upload-packages.yaml` workflow.

The value of this input is passed as an environment variable to the `rapids-upload-to-anaconda` script.

With the PR below merged, this will allow repositories to specify a space-delimited list of `conda` package names that should not be uploaded to Anaconda.org.

- rapidsai/gha-tools#32

It can be used like this:

```yaml
upload-conda:
    uses: rapidsai/shared-action-workflows/.github/workflows/conda-upload-packages.yaml@main
    with:
      skip_upload_pkgs: pkg1 pkg2 pkg3

upload-conda:
    uses: rapidsai/shared-action-workflows/.github/workflows/conda-upload-packages.yaml@main
    with:
      skip_upload_pkgs: >-
        pkg1
        pkg2
        pkg3
```
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ajschmidt8 ajschmidt8 merged commit 4313d11 into main Jan 6, 2023
@ajschmidt8 ajschmidt8 deleted the skip-uploads-feature branch January 6, 2023 03:55
ajschmidt8 added a commit to ajschmidt8/cudf that referenced this pull request Feb 1, 2023
When initially created, the GitHub Actions scripts that upload conda packages would upload all packages that were built indiscriminately.

As a result, the `libcudf-example` package has been uploading to Anaconda.org. It was not previously uploaded to Anaconda.org prior to migrating to GitHub Actions.

While this isn't a huge deal, I recently added some functionality ([here](rapidsai/shared-workflows#33)) that allows us to specify package names that shouldn't be uploaded to Anaconda.org in our workflows.

This PR adds the `libcudf-example` package to the list of packages that should not be uploaded to Anaconda.org
raydouglass pushed a commit to rapidsai/cudf that referenced this pull request Feb 1, 2023
When initially created, the GitHub Actions scripts that upload conda packages would upload all packages that were built indiscriminately.

As a result, the `libcudf-example` package has been uploading to Anaconda.org. It was not previously uploaded to Anaconda.org prior to migrating to GitHub Actions.

While this isn't a huge deal, I recently added some functionality ([here](rapidsai/shared-workflows#33)) that allows us to specify package names that shouldn't be uploaded to Anaconda.org in our workflows.

This PR adds the `libcudf-example` package to the list of packages that should not be uploaded to Anaconda.org

Authors:
   - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
   - Ray Douglass (https://github.com/raydouglass)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants