Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CUDA 12.8.0. #271

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Open

Update to CUDA 12.8.0. #271

wants to merge 1 commit into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 23, 2025

Updates shared-workflows to use CUDA 12.8.0.

Depends on rapidsai/ci-imgs#231.

@bdice bdice requested a review from a team as a code owner January 23, 2025 20:35
@bdice bdice requested a review from KyleFromNVIDIA January 23, 2025 20:35
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but generally seems fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we're keeping around one 12.2.2 job, should we also keep one 12.5.1 job as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question applies to the other files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see that this is already being discussed in rapidsai/ci-imgs#231 (comment). Let's continue discussion over there instead of bifurcating here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the resources to expand the number of jobs in the matrix any further. We can keep [12.0, (12.2 or 12.5), 12.8]. This looks like it will be [12.0, 12.2, 12.8] from the discussions on the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants