Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.9 from workflows. #235

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Drop Python 3.9 from workflows. #235

merged 1 commit into from
Aug 13, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 12, 2024

@bdice bdice requested a review from a team as a code owner August 12, 2024 23:46
@bdice bdice requested a review from KyleFromNVIDIA August 12, 2024 23:46
@bdice bdice mentioned this pull request Aug 12, 2024
Closed
11 tasks
@bdice
Copy link
Contributor Author

bdice commented Aug 12, 2024

@jameslamb I went ahead and opened this because we need to drop Python 3.9 from our workflows in order to update our Dask pinning.

xref: rapidsai/build-planning#88 (comment)

@bdice bdice mentioned this pull request Aug 12, 2024
Closed
3 tasks
@bdice
Copy link
Contributor Author

bdice commented Aug 13, 2024

  1. Here is a test PR in cudf to ensure that this matrix is usable: Test dropping Python 3.9 from shared workflows. cudf#16539
  2. Let's merge Remove hardcoded versions from workflows. cudf#16540 before we merge this PR to avoid disruption in tests. There are no other instances of this in RAPIDS (search link), just those two in cuDF.

@jakirkham jakirkham requested a review from jameslamb August 13, 2024 00:07
jameslamb
jameslamb approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes totally, I support it! Won't hurt to have a bit denser coverage of Python 3.10 in the interim, maybe it'll help catch something.

And I've approved rapidsai/cudf#16540, thanks for thinking of that.

@jakirkham
Copy link
Member

/merge

@raydouglass raydouglass merged commit 06b25f3 into branch-24.10 Aug 13, 2024
@bdice bdice mentioned this pull request Aug 13, 2024
Merged
2 tasks
@jakirkham
Copy link
Member

AFAIK the branch drop-python-3.9 is unused in any workflow. So will go ahead and delete it. If I've missed something, it is easy to restore that branch

@jakirkham jakirkham deleted the drop-python-3.9 branch August 13, 2024 21:48
@jakirkham
Copy link
Member

Thanks all! 🙏

This was referenced Aug 21, 2024
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this pull request Aug 22, 2024
@jameslamb
Drop Python 3.9 support (#272)
c72e739 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham
  - Bradley Dice (https://github.com/bdice)

URL: #272
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Aug 22, 2024
@jameslamb
Drop Python 3.9 support (#1659)
a7b9d37 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham

URL: #1659
This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this pull request Aug 22, 2024
@jameslamb
Drop Python 3.9 support (#766)
de6bfbb 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Gregory Lee (https://github.com/grlee77)
  - https://github.com/jakirkham
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #766
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Aug 22, 2024
@jameslamb
Drop Python 3.9 support (#684)
e13d954 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #684
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this pull request Aug 22, 2024
@jameslamb
Drop Python 3.9 support (#623)
b49f785 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #623
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Aug 22, 2024
@jameslamb
Drop Python 3.9 support (#1377)
49ebabc 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham

URL: #1377
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#443)
8a1a1cd 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham

URL: #443
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#1065)
2d2dbcf 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham

URL: #1065
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#301)
3b5ef26 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham

URL: #301
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#1443)
e323178 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - https://github.com/jakirkham

URL: #1443
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#2417)
73dc36c 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham

URL: #2417
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#6040)
2398624 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #6040
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this pull request Aug 23, 2024
@jameslamb
Drop Python 3.9 support (#209)
9b877a4 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #209
@jameslamb jameslamb mentioned this pull request Aug 23, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Aug 26, 2024
@jameslamb
Drop Python 3.9 support (#4625)
73a2a84 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)
  - Brad Rees (https://github.com/BradReesWork)

URL: #4625
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Aug 27, 2024
@jameslamb
Drop Python 3.9 support (#16637)
efa9770 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #16637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@jameslamb jameslamb jameslamb approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @jakirkham @raydouglass @jameslamb @KyleFromNVIDIA