Fail if the computed matrix is empty. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2024
ajschmidt8
reviewed
Mar 4, 2024
|
@ajschmidt8 It doesn't seem like the I tried this locally and (edit: mashed the close button by accident) |
|
Verified in https://github.com/rapidsai/cudf/actions/runs/8144434095/job/22258595781?pr=15221 This works as desired. |
ajschmidt8
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
compute-matrixjob passes even if the computed matrix is empty. Empty matrices raise an error (as shown below) so this should not be permitted.This is tested in rapidsai/cudf#15221.