Add test summaries to wheel jobs #173
Conversation
| @@ -24,7 +24,11 @@ on: | |||
| container-options: | |||
| required: false | |||
| type: string | |||
| default: '-e _NOOP' | |||
| default: "-e _NOOP" | |||
| test_summary_show: | |||
There was a problem hiding this comment.
By default, the test-summary action shows output from each of the failures (show: "fail"). Since we have a large absolute number of failures in the cudf.pandas test suite (overall it's mostly passing but there are a ton of tests), the output exceeds the GitHub summary size limit. I needed to add this so that we could hide the summary like this:
# Hide test failures because they exceed the GITHUB_STEP_SUMMARY output limit.
test_summary_show: "none"
Should I add this test_summary_show option to .github/workflows/conda-cpp-tests.yaml or .github/workflows/conda-python-tests.yaml, too? Or just leave it on the wheel jobs until it is needed elsewhere?
There was a problem hiding this comment.
Should I add this test_summary_show option to .github/workflows/conda-cpp-tests.yaml or .github/workflows/conda-python-tests.yaml, too? Or just leave it on the wheel jobs until it is needed elsewhere?
Up to you. I don't expect this option to be widely used, so I'm fine with omitting it from the other workflows until it's needed.
| @@ -24,7 +24,11 @@ on: | |||
| container-options: | |||
| required: false | |||
| type: string | |||
| default: '-e _NOOP' | |||
| default: "-e _NOOP" | |||
| test_summary_show: | |||
There was a problem hiding this comment.
Should I add this test_summary_show option to .github/workflows/conda-cpp-tests.yaml or .github/workflows/conda-python-tests.yaml, too? Or just leave it on the wheel jobs until it is needed elsewhere?
Up to you. I don't expect this option to be widely used, so I'm fine with omitting it from the other workflows until it's needed.
This PR fixes issues with the `pandas-tests` job that were introduced during the pandas 2 migration. It also closes #14846 by adding GitHub Actions summaries for all wheel test jobs, including `cudf.pandas`. Depends on rapidsai/shared-workflows#173. Authors: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) - Ashwin Srinath (https://github.com/shwina) Approvers: - Ashwin Srinath (https://github.com/shwina) - Vyas Ramasubramani (https://github.com/vyasr) - Jake Awe (https://github.com/AyodeAwe) URL: #14847
This PR adds test summaries to wheel jobs. Supports rapidsai/cudf#14847 for cudf.pandas test summaries.