-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run wheels-publish jobs in Python 3.11 image #169
Conversation
# it's simply a launcher for twine | ||
image: "rapidsai/ci-wheel:cuda12.0.1-centos7-py3.10" | ||
# CUDA toolkit version of the container is irrelevant in the publish step. | ||
# This just uploads already-built wheels to remote storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow no longer uses twine
, as of #154.
Proposing changing this comment to something more future-proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this change but I would consider delaying the merge this until we begin work (or complete work) on rapidsai/build-planning#3, currently targeting release 24.04. It doesn't benefit us very much to jump ahead with a new Python version until it's widely used across RAPIDS. Moving all of RAPIDS in lockstep is my preference.
Ok makes sense, thanks for that! I agree, this should only be merged as part of rapidsai/build-planning#3, in whatever release that targets. |
I converted this to a draft for now. We can reopen once we're moving forward on Python 3.11. |
The Python version used in this jobs can safely be decoupled from everything else, but conceptually I'm fine with keeping things in sync. No rush here. |
As we are now adding Python 3.11, marking ready for review |
I created a test PR for cudf here: rapidsai/cudf#15227 If that passes, we can close it and merge this PR. |
I realized that the |
Contributes to rapidsai/build-planning#7.
Split off from #166.
This proposes upgrading the image used in the
wheels-publish
workflow to a newer Python version (3.10 -> 3.11
).Benefits of this change
Delays similar updates further into the future (e.g.
aws
andanaconda-client
will drop Python 3.10 support before they drop Python 3.11 support).How I tested this
This workflow just runs this script: https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-wheels-anaconda.
So just checked that the things that script needs are in the image.
I think that's probably sufficient. It'd be easy to revert this if it breaks something... less effort and lower-risk than trying to test on another repo where this
wheels-publish
only runs on merges tomain
.