-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Python requirements in setup.cfg
and rmm_dev.yml
#982
Bump Python requirements in setup.cfg
and rmm_dev.yml
#982
Conversation
While you're at it, I think it'd be nice to also update this file? |
Good catch @leofang. Other places referencing Python 3.7:
|
setup.cfg
setup.cfg
and rmm_dev.yml
Co-authored-by: Bradley Dice <[email protected]>
…ump-python-310-setupcfg
… bump-python-310-setupcfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ashwin! 😀
Had a couple questions below
@@ -10,7 +10,7 @@ dependencies: | |||
- flake8=3.8.3 | |||
- black=19.10 | |||
- isort=5.6.4 | |||
- python>=3.7,<3.9 | |||
- python>=3.8,<3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the upper bound here? Just wondering since we are dropping elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes -- these are the .yml
files used to create dev environments. Since we don't typically want development with 3.10, we keep the upper bound here. This doesn't stop developers from manually building RMM with Python 3.10 if they desire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to do something like the following?
conda create -f rmm_dev_env.yml python=3.9
If so, we can (in theory) drop the upper bound here and make it the developer's responsibility to specify which Python they want to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a good idea — I have seen other packages specify a yml with a user-provided python spec (edit: apparently this is not a thing, I was wrong). Then update the README/docs to include that specification in the commands to create a conda environment.
On that note, it might even make sense to remove the upper bound (use >=11.5) for cudatoolkit and recommend that users pick their version as needed, instead of maintaining two environment files for 11.5 and 11.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is that a valid conda
command, and does it do the expected thing here (override the python spec in the .yml
?)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darn. @shwina I could have sworn I had seen this before but the specifiers after -f stuff.yml
are ignored, so you can't do what I was suggesting. Sorry about that. 😢
Co-authored-by: jakirkham <[email protected]>
rerun tests |
This PR has been labeled |
@shwina what's holding this PR up? Is it just waiting on a resolution of the upper bound question above? |
@vyasr I think that discussion can be resolved. This should be good to merge front m my perspective. |
@bdice @jakirkham let me know if either of you thinks that discussion is a blocker, otherwise I'll aim to merge this by EOD to get ahead of burndown. Trying to avoid surprises ahead of code freeze mid-GTC. |
Nothing blocking from me |
Received approval from @bdice offline. Merging now |
@gpucibot merge |
No description provided.