Update librmm recipe to output librmm_tests package
#978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
non-breaking
ajschmidt8
changed the title
librmm recipe to include test packagelibrmm recipe to output librmm_tests package
|
The |
|
The |
ajschmidt8
force-pushed
the
update-recipes
branch
from
94ae368 to
2a7f273
Compare
jjacobelli
approved these changes
Feb 15, 2022
This reverts commit c6606f4.
|
rerun tests |
|
@gpucibot merge |
|
There are some issues with this PR that I'll have to address in a follow-up PR. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
This PR is a continuation of #978. Initially I thought we'd be able to do a single top-level build with `build.sh` and then simply run `cmake --install...` for the `Outputs` entries. However, I think this would require us to duplicate the `requirements` for each `Outputs` package in the top-level build, which doesn't seem like a good practice. Instead, this PR changes the recipe to build and install the relevant CMake components during each package's individual build steps. The environment variables are copied between package builds using a [YAML anchor](https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/). Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Jordan Jacobelli (https://github.com/Ethyling) URL: #983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
librmmrecipe to include a new output,librmm_tests.librmm_testsis acondapackage that includes all of the binaries forlibrmm's tests and benchmarks. This PR is a prerequisite for deprecating Project Flash.This also updates the CI scripts to use the new package for tests.