Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow zero-size stream pools #873

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Disallow zero-size stream pools #873

merged 1 commit into from
Sep 17, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented Sep 16, 2021

An exception is now thrown when zero is passed as the size parameter to the cuda_stream_pool constructor. Also adds a test for this exception.

Fixes #871

@harrism harrism requested a review from a team as a code owner September 16, 2021 23:18
@harrism harrism requested review from rongou and cwharris September 16, 2021 23:18
@github-actions github-actions bot added the cpp Pertains to C++ code label Sep 16, 2021
@harrism harrism added non-breaking Non-breaking change bug Something isn't working labels Sep 16, 2021
@harrism harrism requested review from jrhemstad and removed request for cwharris September 16, 2021 23:21
@harrism harrism self-assigned this Sep 17, 2021
@harrism
Copy link
Member Author

harrism commented Sep 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8b9fac8 into rapidsai:branch-21.10 Sep 17, 2021
@divyegala divyegala mentioned this pull request Sep 17, 2021
Merged
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Sep 17, 2021
@divyegala
Accounting for rmm::cuda_stream_pool not having a constructor for 0 s…
65a675f 
…treams (#329)

Comes from this PR rapidsai/rmm#873

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@rongou rongou rongou approved these changes

Assignees

@harrism harrism

Labels
bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Potentially undefined behavior of cuda_stream_pool::get_stream
3 participants
@harrism @rongou @jrhemstad