Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add requirements for rmm #739

Merged
merged 9 commits into from
Mar 31, 2021
Merged

[REVIEW] Add requirements for rmm #739

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
de8059c
add requirements for rmm
galipremsagar Mar 31, 2021
43e762d
copyright
galipremsagar Mar 31, 2021
764990a
remove root level pyproject.toml
galipremsagar Mar 31, 2021
ccabbae
newline
galipremsagar Mar 31, 2021
9b560c8
add extra_requires
galipremsagar Mar 31, 2021
129aa7e
fix extras_require
galipremsagar Mar 31, 2021
5537b85
address reviews
galipremsagar Mar 31, 2021
f8e9050
correct the python pinnings
galipremsagar Mar 31, 2021
e0e4bdd
dev
galipremsagar Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/dev_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Copyright (c) 2021, NVIDIA CORPORATION.

clang==8.0.1
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
flake8==3.8.3
black==19.10b0
isort==5.0.7
cmake-format==0.6.11
12 changes: 12 additions & 0 deletions pyproject.toml → python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# Copyright (c) 2021, NVIDIA CORPORATION.

[build-system]

requires = [
"wheel",
"setuptools",
"numba>=0.49",
"Cython>=0.29,<0.30",
"numpy",
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
]

[tool.black]
line-length = 79
target-version = ["py36"]
Expand Down
Empty file removed python/rmm/tests/__init__.py
View file
Open in desktop
Empty file.
12 changes: 11 additions & 1 deletion python/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# Copyright (c) 2018, NVIDIA CORPORATION.
# Copyright (c) 2018-2021, NVIDIA CORPORATION.

# See the docstring in versioneer.py for instructions. Note that you must
# re-run 'versioneer.py setup' after changing this section, and commit the
# resulting files.


[versioneer]
VCS = git
style = pep440
Expand Down Expand Up @@ -48,3 +49,12 @@ skip=
build
dist
__init__.py


[options]
packages = find:
install_requires =
numpy
numba>=0.49
Cython>=0.29,<0.30
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
python_requires = >=3.6
3 changes: 2 additions & 1 deletion python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ def get_cuda_version_from_header(cuda_include_dir):
"Programming Language :: Python :: 3.7",
],
# Include the separately-compiled shared library
setup_requires=["cython"],
setup_requires=["Cython>=0.29,<0.30"],
extras_requires={"test": ["pytest", "pytest-xdist"]},
ext_modules=extensions,
packages=find_packages(include=["rmm", "rmm.*"]),
package_data=dict.fromkeys(
Expand Down