Remove CMAKE_CURRENT_BINARY_DIR path in rmm's target_include_directories #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
CMAKE_CURRENT_BINARY_DIR
path in rmm'starget_include_directories
.Best I can tell, the build generates a
version_config.hpp
file and places it there for installation later. It doesn't seem to be included by any actual RMM library headers.This breaks
ccache
in a few different ways:rmm/build-dir-1
(note-I rmm/build-dir-1/include
in cuDF compile commands).rmm/build-dir-2
(note-I rmm/build-dir-2/include
in cuDF compile commands).ccache
rebuilds all cuDF source files even though none of the RMM headers actually changed.CPM_SOURCE_CACHE
):CPMFindPackage(cudf ...)
, cuDF and RMM are downloaded and placed inCPM_SOURCE_CACHE
.CPMFindPackage(cudf ...)
, which uses cuDF and RMM source cached inCPM_SOURCE_CACHE
.-I ProjectA/build/_deps/rmm-build/include
and-I ProjectB/build/_deps/rmm-build/include
, respectively.