Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a linear accessor to RMM cuda stream pool #696

Merged
merged 10 commits into from
Feb 8, 2021
Merged

Adds a linear accessor to RMM cuda stream pool #696

merged 10 commits into from
Feb 8, 2021

Conversation

afender
Copy link
Member

@afender afender commented Feb 5, 2021

Adds rmm::cuda_stream_pool::get_stream(stream_id) and rmm::cuda_stream_pool::get_pool_size() accessors which allow legacy compatibility in cuML and immediate adoption of rmm::cuda_stream_pool in RAFT and cuGraph. This co-exist with the current features in rmm::cuda_stream_pool.

close #689

@afender afender requested a review from a team as a code owner February 5, 2021 21:15
@afender afender requested review from rongou and harrism February 5, 2021 21:15
@github-actions github-actions bot added the cpp Pertains to C++ code label Feb 5, 2021
jrhemstad
jrhemstad requested changes Feb 5, 2021
View reviewed changes
include/rmm/cuda_stream_pool.hpp Outdated Show resolved Hide resolved
include/rmm/cuda_stream_pool.hpp Outdated Show resolved Hide resolved
@afender afender requested a review from jrhemstad February 8, 2021 18:30
jrhemstad
jrhemstad requested changes Feb 8, 2021
View reviewed changes
include/rmm/cuda_stream_pool.hpp Outdated Show resolved Hide resolved
include/rmm/cuda_stream_pool.hpp Outdated Show resolved Hide resolved
harrism
harrism approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (funny, I had this implemented in a local experimental branch). Just a comment on a test.

tests/cuda_stream_pool_tests.cpp Outdated Show resolved Hide resolved
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 8, 2021
@afender afender mentioned this pull request Feb 8, 2021
Closed
@harrism
Copy link
Member

harrism commented Feb 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8f18e7f into rapidsai:branch-0.19 Feb 8, 2021
@jrhemstad jrhemstad mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@harrism harrism harrism approved these changes

@rongou rongou rongou approved these changes

Assignees

@afender afender

Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afender @harrism @rongou @jrhemstad