Port to rattler-build #1796
Port to rattler-build #1796
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
gforsyth
force-pushed
the
rattler-test
branch
from
9a224dd to
c79968f
Compare
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
gforsyth
force-pushed
the
rattler-test
branch
from
5af3309 to
be8c03f
Compare
|
@jakirkham @vyasr anything else you'd like to see here? |
gforsyth
force-pushed
the
rattler-test
branch
from
9468e1f to
4e2ec08
Compare
gforsyth
force-pushed
the
rattler-test
branch
from
4e2ec08 to
1bd6cd9
Compare
|
With this migration and rapidsai/gha-tools#143, have we effectively obsoleted |
|
Since we do not, in general, use variant builds in RAPIDS (with the notable exception of ucxx), once we drop CUDA 11 support (i.e. once the compiler version is no longer dependent on the CUDA version) should we also consider inlining the CBC values? If so, can we open an issue to track that work? |
|
I've resolved all threads that I think have been addressed (which is almost all of them). One more pass through old CI reviews to verify would be good, then I think we've got pretty much everything sorted out here. |
I believe that's correct, so we can deprecate it and mark it for future removal. |
|
I opened rapidsai/gha-tools#145. |
Co-authored-by: Vyas Ramasubramani <[email protected]>
|
Issue here to track inlining CBC values once we drop CUDA 11: rapidsai/build-planning#153 |
|
/merge |
|
Thanks Gil for all the hard work getting our first recipe onto Looking forward to converting our next package 🙂 |
Summary: - We use the [multi-output cache](https://rattler.build/latest/multiple_output_cache/) to avoid double-compiling. The `build` environment compiles things, the individual outputs call `cmake --install` - We make use of the built-in `git` functions for grabbing the short-SHA (https://rattler.build/latest/experimental_features/#git-functions) - We use `load_from_file` to pull in metadata from the corresponding `pyproject.toml` (https://rattler.build/latest/experimental_features/#load_from_filefile_path) - Relatively "simple" `*_build.sh` scripts are inlined into `recipe.yaml` instead of existing as separate files - We use `--no-build-id` to allow `sccache` to look in a predictable place, see: https://rattler.build/latest/tips_and_tricks/#using-sccache-or-ccache-with-rattler-build - Depending on whether `rapids-is-release-build`, we include either `rapidsai` (release) or `rapidsai-nightly` (non-release) in the channel listing - Channels must be specified at the command-line - This uses https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-rattler-channel-string to generate an array of channels - We remove the `build_cache` directory after building so it doesn't get packaged up with the other artifacts and uploaded to S3 xref: rapidsai/build-planning#47 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#1796
Summary:
recipe.yamlbuildenvironment compiles things, the individual outputs callcmake --installgitfunctions for grabbing the short-SHA (https://rattler.build/latest/experimental_features/#git-functions)load_from_fileto pull in metadata from the correspondingpyproject.toml(https://rattler.build/latest/experimental_features/#load_from_filefile_path)*_build.shscripts are inlined intorecipe.yamlinstead of existing as separate filesbuild_*.sh--no-build-idto allowsccacheto look in a predictable place, see: https://rattler.build/latest/tips_and_tricks/#using-sccache-or-ccache-with-rattler-buildrapids-is-release-build, we include eitherrapidsai(release) orrapidsai-nightly(non-release) in the channel listingbuild_cachedirectory after building so it doesn't get packaged up with the other artifacts and uploaded to S3xref: rapidsai/build-planning#47