Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 #1729

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 14, 2024

Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

@bdice bdice added non-breaking Non-breaking change feature request New feature or request labels Nov 14, 2024
@github-actions github-actions bot added Python Related to RMM Python API conda labels Nov 14, 2024
@harrism
Copy link
Member

harrism commented Nov 19, 2024

I assume this will move to 25.02?

@bdice
Copy link
Contributor Author

bdice commented Nov 19, 2024

Yes, we are discussing this for 25.02. rapidsai/build-planning#117 has more context. I'll retarget it to 25.02 for now.

@bdice bdice changed the base branch from branch-24.12 to branch-25.02 November 19, 2024 23:39
Copy link

copy-pr-bot bot commented Dec 3, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr
Copy link
Contributor

vyasr commented Dec 3, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Dec 3, 2024

@bdice I've updated this branch. I think we are good to merge now.

@bdice bdice marked this pull request as ready for review December 3, 2024 04:49
@bdice bdice requested a review from a team as a code owner December 3, 2024 04:49
@bdice bdice requested a review from msarahan December 3, 2024 04:49
@bdice
Copy link
Contributor Author

bdice commented Dec 3, 2024

@vyasr Sounds good. I opened this for review. We can merge once reviews are done.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I spot-checked logs and confirmed we're getting the expected versions.

@jameslamb jameslamb removed the request for review from msarahan December 4, 2024 17:22
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 00287e0 into rapidsai:branch-25.02 Dec 5, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda feature request New feature or request non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants