Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct to create associated issue in PR template. #1624

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Jul 22, 2024

We use issues for tracking work and new features in RMM. This adds instruction to the PR template to suggest contributors should create an associated issue if it doesn't already exist.

Fixes #1623

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

We use issues for tracking work and new features in RMM. This adds instruction to the PR template about this.
@harrism harrism added feature request New feature or request doc Documentation non-breaking Non-breaking change labels Jul 22, 2024
@harrism harrism self-assigned this Jul 22, 2024
@harrism harrism requested a review from a team as a code owner July 22, 2024 23:57
@harrism harrism requested a review from msarahan July 22, 2024 23:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (5f786ba) to head (01be425).
Report is 1 commits behind head on branch-24.08.

Additional details and impacted files
@@             Coverage Diff              @@
##           branch-24.08   #1624   +/-   ##
============================================
  Coverage          0.00%   0.00%           
============================================
  Files                10      10           
  Lines               273     273           
============================================
  Misses              273     273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harrism harrism removed the feature request New feature or request label Jul 24, 2024
@harrism
Copy link
Member Author

harrism commented Jul 24, 2024

/merge

@rapids-bot rapids-bot bot merged commit 094675d into branch-24.08 Jul 24, 2024
61 checks passed
@jameslamb jameslamb deleted the fea-PR-create-issue-instructions branch July 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DOC] PR template should instruct contributors to create an issue first.
3 participants