Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python wrapper for system memory resource #1605
Add python wrapper for system memory resource #1605
Changes from 10 commits
1375369
4c9bf49
48e16a9
6deb6fb
283ee01
352ab6d
20a58ac
0ff0a97
35daa57
d1320da
005e522
8663fa6
6041192
2d017e3
39f6978
f8cbf80
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An adaptor accepts another resource as an argument (e.g. a logging adaptor adds logging, but passes through to the underlying MR). This is not an adaptor, it is implemented like an entirely new resource.
Adaptors must be composable. It cannot be specific to the System MR and must accept other MRs if it is to be an adaptor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we redesign this so that the SystemMemoryResource has an argument
headroom
and we don't need the "adaptor" at all? Or rename this so it's not an adaptor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C++ side has both the system mr and the adaptor, but I guess we don't have to strictly mirror it in python. I'd be happy to have a single SystemMemoryResource with an argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.