-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated functionality #1537
Merged
rapids-bot
merged 17 commits into
rapidsai:branch-24.06
from
harrism:fea-remove-deprecated-funcs
Apr 30, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a51cbc3
Remove thrust_rmm_allocator.h
harrism 6c79958
Remove deprecated detail alignment funcs
harrism 9e657b4
Remove deprecated ctors from pool_mr
harrism eeb1c4b
Merge branch 'branch-24.06' into fea-remove-deprecated-funcs
harrism d81f464
Remove deprecated constructor from cuda_async_memory_resource
harrism a4d6c96
Merge branch 'fea-remove-deprecated-funcs' of github.com:harrism/rmm …
harrism 1b60b95
Remove deleted file from conda recipe tests
harrism 2cf9997
Comment out deprecated docs section while there are no deprecated items.
harrism 1dbb39a
Style
harrism 68a7a02
Revert previous docs change.
harrism 9237815
Use conf.py to exclude deprecated page if it doesn't exist.
harrism f9b11ea
style
harrism 4734607
Use append
harrism a8dfafb
Add back removed blank line
harrism a833222
doc copilot-o
harrism f5cb0b7
os.path.join
harrism 73a3ecb
style
harrism File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? I'd guess when you exclude things it generates an extra file and then it warns about that file not being included anywhere, or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
deprecated
is listed in the toc in the main RST file. This lets us leave it there even though the deprecated.rst file is excluded. Without this suppression you get a warning that an excluded file is in the toc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a better way to conditionally remove it from the toc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK I see. Yeah that seems fine then.