Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #1496

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Remove hard-coding of RAPIDS version where possible #1496

merged 8 commits into from
Mar 8, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

  • Read VERSION file from CMake
  • Read rmm.__version__ from docs build
  • Read VERSION file from shell scripts
  • Remove updates from ci/release/update-version.sh

Issue: rapidsai/build-planning#15

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 5, 2024 16:14
@github-actions github-actions bot added CMake Python Related to RMM Python API ci labels Mar 5, 2024
@KyleFromNVIDIA KyleFromNVIDIA added 2 - In Progress Currently a work in progress non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 5, 2024
@jakirkham
Copy link
Member

Thanks Kyle! 🙏

Think we can also make these changes: rapidsai/build-planning#15 (comment) + rapidsai/build-planning#15 (comment)

harrism
harrism reviewed Mar 6, 2024
View reviewed changes
ci/build_docs.sh Outdated Show resolved Hide resolved
@KyleFromNVIDIA KyleFromNVIDIA added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Mar 6, 2024
harrism
harrism approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the cpp Pertains to C++ code label Mar 7, 2024
bdice
bdice reviewed Mar 7, 2024
View reviewed changes
scripts/doxygen.sh Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2cb1ac7 into rapidsai:branch-24.04 Mar 8, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@harrism harrism harrism approved these changes

Assignees

@KyleFromNVIDIA KyleFromNVIDIA

Labels
4 - Needs Reviewer Waiting for reviewer to review or respond ci CMake cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @jakirkham @harrism @bdice @AyodeAwe