Deprecate rmm::mr::device_memory_resource::supports_streams() #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Feb 1, 2024
bdice
approved these changes
Feb 1, 2024
| * @returns bool true if the resource supports non-null CUDA streams. | ||
| */ | ||
| [[nodiscard]] virtual bool supports_streams() const noexcept { return false; } | ||
| [[deprecated("Functionality removed in favor of cuda::mr::async_memory_resource.")]] // |
There was a problem hiding this comment.
Extraneous comment?
Suggested change
| [[deprecated("Functionality removed in favor of cuda::mr::async_memory_resource.")]] // | |
| [[deprecated("Functionality removed in favor of cuda::mr::async_memory_resource.")]] |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates now unused
device_memory_resource::supports_streams(). Will be removed in next release (24.06).Merge after:
Closes #1433
Checklist