-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device_async_resource_ref convenience alias #1441
Add device_async_resource_ref convenience alias #1441
Conversation
Want to add a test? |
You could probably drop the "async" since RMM's allocation APIs have always been async and it's well understood at this point. So It wouldn't hurt anything to drop the |
RMM has always had some MRs that are synchronous (e.g. If I remove |
Answered my own question. Moved the header up a level and move up to rmm:: namespace. This is now shorter spelling than the resource pointer used by RAPIDS libraries, so it's a net win:
|
/merge |
Description
Adds a new header
include/rmm/resource_ref.hpp
that currently just contains a singleusing
alias to make it easier to spell a device-accessible async_resource_ref.Closes #1442
rmm::device_async_resource_ref
is an alias forcuda::mr::async_resource_ref<cuda::mr::device_accessible>
.This is 30 characters vs. 57. It is shorter than the currently used resource pointer spelling:
rmm::mr::device_memory_resource*
.Also updates tests to use this alias.
Also makes one unrelated doc change, I noticed
pinned_host_memory_resource
was not added to a doxygen group, so I fixed that.I was going to put this in cuDF, but @bdice suggested maybe it would be useful to have it in RMM.