Adding identify minimum version requirement #1301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into an issue with clang-format not being able to run due to the version of identify I had installed.
This led me to find out that pre-commit only requires version 1, but we require a newer version to work with clang-format. We don't specify that version anywhere, so I tracked down the minimum requirement and added it in our dependencies.yaml and ran pre-commit to update the conda environment files.
I verified that version 2.5.19 did not have textproto, but 2.5.20 did have it and that is why 2.5.20 is the minimum required version.
Checklist