Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to allow spdlog to be compiled. #1232

Closed
wants to merge 8 commits into from
Closed

Adding option to allow spdlog to be compiled. #1232

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d3725d6
Adding option to allow spdlog to be compiled.
cjnolet Mar 15, 2023
e060dc2
Fixing conditional link target
cjnolet Mar 15, 2023
559fdf5
Style
cjnolet Mar 15, 2023
d478bc3
Tryign to make style checker happy
cjnolet Mar 15, 2023
5981996
Using pre-commit to format properly
cjnolet Mar 15, 2023
cf60206
Review feedback- using consistent naming for option everywhere
cjnolet Mar 16, 2023
04dc75d
Adding Robert Maynard's feedback.
cjnolet Mar 29, 2023
5f0a65f
Merge branch 'branch-23.04' into imp-2304-allow_spdlog_compiled
cjnolet Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ rapids_cmake_build_type(Release)
# build options
option(BUILD_TESTS "Configure CMake to build tests" ON)
option(BUILD_BENCHMARKS "Configure CMake to build (google) benchmarks" OFF)
option(RMM_COMPILED "Use spdlog compiled library. Header-only version is used otherwise" OFF)
cjnolet marked this conversation as resolved.
Show resolved Hide resolved
set(RMM_LOGGING_LEVEL
"INFO"
CACHE STRING "Choose the logging level.")
Expand Down Expand Up @@ -77,9 +78,13 @@ else()
target_link_libraries(rmm INTERFACE CUDA::cudart)
endif()

message(STATUS "RMM: Use SPDLOG Compiled: ${RMM_SPDLOG_COMPILED}")
cjnolet marked this conversation as resolved.
Show resolved Hide resolved

target_link_libraries(rmm INTERFACE rmm::Thrust)
target_link_libraries(rmm INTERFACE fmt::fmt-header-only)
target_link_libraries(rmm INTERFACE spdlog::spdlog_header_only)
target_link_libraries(rmm INTERFACE $<$<BOOL:NOT
${RMM_SPDLOG_COMPILED}>:spdlog::spdlog_header_only>)
target_link_libraries(rmm INTERFACE $<$<BOOL:${RMM_SPDLOG_COMPILED}>:spdlog::spdlog>)
target_link_libraries(rmm INTERFACE dl)
target_compile_features(rmm INTERFACE cxx_std_17 $<BUILD_INTERFACE:cuda_std_17>)

Expand Down