Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TRACKING_TEST only works with RMM_LOGGING_LEVEL=DEBUG #928

Closed
rongou opened this issue Dec 3, 2021 · 1 comment · Fixed by #929
Closed

[BUG] TRACKING_TEST only works with RMM_LOGGING_LEVEL=DEBUG #928

rongou opened this issue Dec 3, 2021 · 1 comment · Fixed by #929
Assignees
@harrism
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@rongou
Copy link
Contributor

rongou commented Dec 3, 2021 •
edited
Loading

Describe the bug
After #920 is merged, running tests from head fails:

[ RUN      ] TrackingTest.LogOutstandingAllocations
/home/rou/src/rmm/tests/mr/device/tracking_mr_tests.cpp:217: Failure
Expected: (oss.str().find("Outstanding Allocations")) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615

Steps/Code to reproduce bug
Sync to head, run cmake and ninja, invoke ./gtests/TRACKING_TEST.

Expected behavior
Tests should pass with the default configuration.

Environment details (please complete the following information):

  • Environment location: Bare-metal
  • Method of RMM install: from source

Additional context
Seems like the logging level is determined at compile time, while the test is trying to modify it at runtime. The only way to get the test to pass is to run cmake .. -DRMM_LOGGING_LEVEL=DEBUG.
@rongou rongou added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 3, 2021
@harrism
Copy link
Member

harrism commented Dec 3, 2021

oops, looking.

@harrism harrism mentioned this issue Dec 3, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #929 Dec 6, 2021
rapids-bot bot pushed a commit that referenced this issue Dec 6, 2021
@harrism
Fix failing tracking test (#929)
bd5aa5d 
Fixes #928.

#920 introduced a new test for the `tracking_resource_adaptor::log_outstanding_allocations`, but that function only logs when `SPDLOG_ACTIVE_LEVEL <= SPDLOG_LEVEL_DEBUG`, so the test needs to be gated on that condition as well.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Rong Ou (https://github.com/rongou)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)

URL: #929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failing tracking test harrism/rmm
2 participants
@rongou @harrism