Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Make CMake style check used in CI easy to run locally #903

Closed
vyasr opened this issue Nov 3, 2021 · 2 comments · Fixed by #913
Closed

[FEA] Make CMake style check used in CI easy to run locally #903

vyasr opened this issue Nov 3, 2021 · 2 comments · Fixed by #913
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Nov 3, 2021

Is your feature request related to a problem? Please describe.
I'd like for it to be easy to run the CMake linters locally. The details of the request were originally posted in rapidsai/cudf#9396.

Describe the solution you'd like
A port of the solution from rapidsai/cudf#9484 would enable local cmake-format runs either via script or through pre-commit.
@vyasr vyasr added ? - Needs Triage Need team to review and classify feature request New feature or request labels Nov 3, 2021
@vyasr
Copy link
Contributor Author

vyasr commented Nov 3, 2021

CC @harrism

@harrism
Copy link
Member

harrism commented Nov 4, 2021

@vyasr Thanks! Go for it if you have time. I would love to be able to cmake-format my current PR...

@vyasr vyasr mentioned this issue Nov 10, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #913 Nov 18, 2021
rapids-bot bot pushed a commit that referenced this issue Nov 18, 2021
@vyasr
Simplify CMake linting with cmake-format (#913)
27715b1 
This PR adds a script to find the cmake-format-rapids-cmake.json file in a standard location and run the cmake-format or cmake-lint programs with that config file. The script fails gracefully when the file cannot be found and is therefore suitable for use as a pre-commit hook in scenarios where no build directory (containing the config file) exists yet. A corresponding pre-commit configuration is added here as well, replacing the old cmake-format hook which did not use the rapids-cmake config file.

Resolves #903.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Robert Maynard (https://github.com/robertmaynard)
  - Rong Ou (https://github.com/rongou)

URL: #913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify CMake linting with cmake-format vyasr/rmm
2 participants
@harrism @vyasr