Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] aligned_resource_adaptor.hpp doesn't compile #819

Closed
trxcllnt opened this issue Jul 14, 2021 · 1 comment · Fixed by #820
Closed

[BUG] aligned_resource_adaptor.hpp doesn't compile #819

trxcllnt opened this issue Jul 14, 2021 · 1 comment · Fixed by #820
Assignees
@rongou
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@trxcllnt
Copy link
Contributor

rmm/mr/aligned_resource_adaptor.hpp fails to compile with this error:

aligned_resource_adaptor.hpp:212:39: error: 'align_up' is not a member of 'rmm::mr::detail'; did you mean 'rmm::detail::align_up'
@trxcllnt trxcllnt added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jul 14, 2021
@harrism
Copy link
Member

harrism commented Jul 14, 2021

Are there not tests of this adaptor? Assigning @rongou since he created it recently.

@rongou rongou mentioned this issue Jul 15, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #820 Jul 17, 2021
rapids-bot bot pushed a commit that referenced this issue Jul 17, 2021
@rongou
fix align_up namespace in aligned_resource_adaptor.hpp (#820)
2179ffd 
Fixes #819

Authors:
  - Rong Ou (https://github.com/rongou)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Conor Hoekstra (https://github.com/codereport)

URL: #820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rongou rongou

Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix align_up namespace in aligned_resource_adaptor.hpp rongou/rmm
3 participants
@trxcllnt @rongou @harrism