Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_upstream_resource method to resource adaptors to eventually replace raw get_upstream #1455

Closed
Tracked by #1445
miscco opened this issue Feb 2, 2024 · 0 comments · Fixed by #1456
Closed
Tracked by #1445
Assignees
Labels
feature request New feature or request

Comments

@miscco
Copy link
Contributor

miscco commented Feb 2, 2024

No description provided.

@miscco miscco added the feature request New feature or request label Feb 2, 2024
@miscco miscco self-assigned this Feb 2, 2024
miscco added a commit to miscco/rmm that referenced this issue Feb 2, 2024
We want to get rid of the raw `get_upstream` method. In order to achieve that we need to add an alternative that is based on our new `rmm::device_async_resource_ref`

I am a stickler to consistency so I also cleaned the documentation of `get_upstream` up and added `[[nodiscard]]`

closes rapidsai#1455
@harrism harrism moved this from Todo to Review in RMM Project Board Feb 5, 2024
rapids-bot bot pushed a commit that referenced this issue Feb 29, 2024
We want to get rid of the raw `get_upstream` method. In order to achieve that we need to add an alternative that is based on our new `rmm::device_async_resource_ref`

I am a stickler to consistency so I also cleaned the documentation of `get_upstream` up and added `[[nodiscard]]`

closes #1455

Authors:
  - Michael Schellenberger Costa (https://github.com/miscco)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1456
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant