Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove supports_streams() from memory resources #1389

Closed
3 tasks done
Tracked by #16
, #1443
...
harrism opened this issue Nov 23, 2023 · 0 comments · Fixed by #1519
Closed
3 tasks done
Tracked by #16
, #1443
...

Deprecate and remove supports_streams() from memory resources #1389

harrism opened this issue Nov 23, 2023 · 0 comments · Fixed by #1519
Assignees
@harrism
Labels
cpp Pertains to C++ code feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Nov 23, 2023 •
edited
Loading

As we move to replace device_memory_resource and host_memory_resource as dichotomous base classes in favor of the cuda::memory_resource concept, I think where possible we should deprecate features of the former that are not part of the interface defined by the latter.

Let's deprecate and remove the little-used rmm::mr::device_memory_resource::supports_streams().

Tasks
Preview Give feedback
  1. Make rmm::mr::device_memory_resource::supports_streams() not pure virtual, remove derived implementations. #1432
    cpp feature request
    harrism
  2. Deprecatermm::mr::device_memory_resource::supports_streams(). #1433
    cpp feature request
    harrism
  3. Remove deprecated rmm::mr::device_memory_resource::supports_streams(). #1434
    cpp
    harrism
@harrism harrism added feature request New feature or request cpp Pertains to C++ code labels Nov 23, 2023
@harrism harrism changed the title [FEA] Deprecate and remove supports_streams() from memory resources Deprecate and remove supports_streams() from memory resources Nov 23, 2023
@harrism harrism mentioned this issue Jan 9, 2024
Merged
3 tasks
@harrism harrism mentioned this issue Jan 24, 2024
Merged
3 tasks
@harrism harrism moved this from Todo to In Progress in RMM Project Board Jan 24, 2024
This was referenced Jan 24, 2024
Merged
Merged
@harrism harrism self-assigned this Jan 24, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 26, 2024
@harrism
Make device_memory_resource::supports_streams() not pure virtual. Rem…
19d8ef9 
…ove derived implementations and calls in RMM (#1437)

Closes #1432. Part of #1389 

- Make supports_streams() nonpure
- Remove supports_streams() from all MRs and tests.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Michael Schellenberger Costa (https://github.com/miscco)

URL: #1437
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Jan 26, 2024
@harrism
Remove supports_streams from cuDF custom memory resources. (#14857)
b47f5ee 
Part of rapidsai/rmm#1389. This removes now-optional and soon-to-be deprecated `supports_streams()` from cuDF's custom `device_memory_resource` implementations.

Depends on rapidsai/rmm#1437

Authors:
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)
  - Yunsong Wang (https://github.com/PointKernel)
  - Michael Schellenberger Costa (https://github.com/miscco)

URL: #14857
This was referenced Jan 30, 2024
Open
Open
Closed
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Feb 1, 2024
@harrism
Remove supports_streams from custom RAFT memory resources (#2121)
3c87b92 
Part of rapidsai/rmm#1389. This removes now-optional and soon-to-be deprecated `supports_streams()` from RAFT's custom `device_memory_resource` implementations.

Authors:
  - Mark Harris (https://github.com/harrism)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2121
mythrocks added a commit to mythrocks/spark-rapids-jni that referenced this issue Mar 7, 2024
@mythrocks
Remove deprecated supports_streams()
1255168 
Fixes NVIDIA#1814.

This change removes the override of `spark_resource_adaptor::supports_stream()`,
in light of rapidsai/rmm#1389, which deprecated the
method.

Similar to rapidsai/cudf#14857, this change removes
the deprecated override.

Signed-off-by: MithunR <[email protected]>
@mythrocks mythrocks mentioned this issue Mar 7, 2024
Merged
mythrocks added a commit to NVIDIA/spark-rapids-jni that referenced this issue Mar 10, 2024
@mythrocks
Remove deprecated supports_streams() (#1847)
c8b71a0 
Fixes #1814.

This change removes the override of `spark_resource_adaptor::supports_stream()`,
in light of rapidsai/rmm#1389, which deprecated the
method.

Similar to rapidsai/cudf#14857, this change removes
the deprecated override.

Signed-off-by: MithunR <[email protected]>
@harrism harrism mentioned this issue Apr 4, 2024
Merged
3 tasks
@harrism harrism moved this from In Progress to Review in RMM Project Board Apr 4, 2024
@rapids-bot rapids-bot bot closed this as completed in #1519 Apr 5, 2024
@rapids-bot rapids-bot bot closed this as completed in 48820cb Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
cpp Pertains to C++ code feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated supports_streams and get_mem_info methods. harrism/rmm
1 participant
@harrism