Skip to content

Commit

Permalink
Specify include_package_data to setup (#1218)
Browse files Browse the repository at this point in the history
For pure setuptools-based builds, the `include_package_data` option historically defaulted to False. With newer projects, i.e. with projects containing a pyproject.toml file, it defaults to True. However, for projects using scikit-build this setting must be provided explicitly to the `setup` function (not in the config file) to allow scikit-build to intercept the argument and use it in the preprocessing it does before invoking `setuptools.setup`.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - https://github.com/jakirkham

URL: #1218
  • Loading branch information
vyasr authored Feb 22, 2023
1 parent ebf591f commit c085cdb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@

setup(
packages=find_packages(include=["rmm", "rmm.*"]),
include_package_data=True,
)

0 comments on commit c085cdb

Please sign in to comment.