Skip to content

Commit

Permalink
upgrade spdlog to 1.8.5 (#658)
Browse files Browse the repository at this point in the history
The new version includes `fmt` version 7.1.3 which fixed the problem with cuda 10.x.

@harrism @kkraus14

Authors:
  - Rong Ou (https://github.com/rongou)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - Mark Harris (https://github.com/harrism)
  - Mike Wendt (https://github.com/mike-wendt)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #658
  • Loading branch information
rongou authored May 24, 2021
1 parent 8a6baa0 commit a4c21d7
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion ci/gpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ conda activate rapids
gpuci_conda_retry install rapids-build-env=${MINOR_VERSION}.*

# https://docs.rapids.ai/maintainers/depmgmt/
# conda remove -f rapids-build-env
# conda remove --force rapids-build-env
# gpuci_conda_retry install "your-pkg=1.0.0"

gpuci_logger "Check versions"
Expand Down
2 changes: 1 addition & 1 deletion cmake/Modules/RMM_thirdparty.cmake
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# spdlog

set(RMM_MIN_VERSION_spdlog 1.7.0)
set(RMM_MIN_VERSION_spdlog 1.8.5)

if(NOT TARGET spdlog)
CPMFindPackage(
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda10.1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ dependencies:
- cffi>=1.10.0
- pytest
- cudatoolkit=10.1
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cython>=0.29,<0.30
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda10.2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ dependencies:
- cffi>=1.10.0
- pytest
- cudatoolkit=10.2
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cython>=0.29,<0.30
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda11.0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ dependencies:
- cffi>=1.10.0
- pytest
- cudatoolkit=11.0
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cython>=0.29,<0.30
2 changes: 1 addition & 1 deletion conda/recipes/librmm/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ requirements:
- cudatoolkit {{ cuda_version }}.*
run:
- {{ pin_compatible('cudatoolkit', max_pin='x.x') }}
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0

test:
commands:
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/rmm/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ requirements:
- librmm {{ version }}
- setuptools
- cython >=0.29,<0.30
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cudatoolkit {{ cuda_version }}.*
run:
- python
Expand Down

0 comments on commit a4c21d7

Please sign in to comment.