Skip to content

Commit

Permalink
fix release script version updater based on cmake reformatting(#639)
Browse files Browse the repository at this point in the history
There was a cmake formatting change in #604 and the ci script that bumps versions at release time was not updated to account for it properly. This fixes the script.

Authors:
  - Keith Kraus <[email protected]>

Approvers:
  - Ray Douglass

URL: #639
  • Loading branch information
kkraus14 authored Dec 1, 2020
1 parent 22f8f0e commit 9da2a0b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
- PR #621 Make `rmm::cuda_stream_default` a `constexpr`
- PR #625 Use `librmm` conda artifact when building `rmm` conda package
- PR #634 Fix conda uploads
- PR #639 Fix release script version updater based on CMake reformatting


# RMM 0.16.0 (21 Oct 2020)

Expand Down
2 changes: 1 addition & 1 deletion ci/release/update-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function sed_runner() {
sed -i.bak ''"$1"'' $2 && rm -f ${2}.bak
}

sed_runner 's/'"RMM VERSION .* LANGUAGES"'/'"RMM VERSION ${NEXT_FULL_TAG} LANGUAGES"'/g' CMakeLists.txt
sed_runner 's/'" VERSION .*"'/'" VERSION ${NEXT_FULL_TAG} LANGUAGES"'/g' CMakeLists.txt

sed_runner 's/version=.*/version=\"'"${NEXT_FULL_TAG}"'\",/g' python/setup.py

Expand Down

0 comments on commit 9da2a0b

Please sign in to comment.