Skip to content

Commit

Permalink
Temporarily disable warnings for unknown pragmas (#942)
Browse files Browse the repository at this point in the history
CUB 1.15 has uses an unprotected `#pragma nv_exec_check_disable` which makes includes of thrust headers from .cpp files fail if `-Werror` is enabled (or warn if it is not set)

This PR is a temporary workaround. It just adds -Wno-unknown-pragmas to the command line for building benchmark .cpp files.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

URL: #942
  • Loading branch information
harrism authored Jan 12, 2022
1 parent ea807e8 commit 5584a0c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ function(ConfigureBench BENCH_NAME)
target_compile_definitions(${TEST_NAME} PUBLIC "RMM_DISABLE_CUDA_MALLOC_ASYNC")
endif()

target_compile_options(${BENCH_NAME} PUBLIC $<$<COMPILE_LANG_AND_ID:CXX,GNU,Clang>:-Wall -Werror
-Wno-error=deprecated-declarations>)
target_compile_options(
${BENCH_NAME} PUBLIC $<$<COMPILE_LANG_AND_ID:CXX,GNU,Clang>:-Wall -Werror
-Wno-error=deprecated-declarations -Wno-unknown-pragmas>)
if(DISABLE_DEPRECATION_WARNING)
target_compile_options(
${BENCH_NAME} PUBLIC $<$<COMPILE_LANGUAGE:CUDA>:-Xcompiler=-Wno-deprecated-declarations>)
Expand Down

0 comments on commit 5584a0c

Please sign in to comment.