Skip to content

Commit

Permalink
Compile Cython with C++17. (#787)
Browse files Browse the repository at this point in the history
#741 moved the code base over to C++17, and as discussed in #736 moving Cython compilation over is fine as well but has not been done yet. There's some use of structured bindings in there now (in `cuda_async_memory_resource.hpp`) so the Cython compilation should be switched over as well.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - https://github.com/jakirkham
  - Mark Harris (https://github.com/harrism)

URL: #787
  • Loading branch information
vyasr authored Jun 1, 2021
1 parent 139ea5b commit 47f5522
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def get_cuda_version_from_header(cuda_include_dir):
],
libraries=["cuda", "cudart"],
language="c++",
extra_compile_args=["-std=c++14"],
extra_compile_args=["-std=c++17"],
)
],
nthreads=nthreads,
Expand Down

0 comments on commit 47f5522

Please sign in to comment.