-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callback sink and default pattern access #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with one question.
@@ -36,9 +36,13 @@ | |||
#include <spdlog/sinks/null_sink.h> | |||
#include <spdlog/sinks/ostream_sink.h> | |||
#include <spdlog/spdlog.h> | |||
#include <spdlog/details/log_msg.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid this detail include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the officially documented way of creating custom loggers is to define overloads like this method that require this type. We could probably remove the include and rely on getting the type transitively, but we still have to access the type from the details
namespace.
These features are required by cuml.