update pre-commit hook versions, use new ruff config format #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
rjzamora
approved these changes
Sep 11, 2024
Comment on lines
+35
to
+46
| # pycodestyle (errors) | ||
| "E", | ||
| # isort | ||
| "I", | ||
| # pyflakes | ||
| "F", | ||
| # pep8-naming | ||
| "N", | ||
| # pyupgrade | ||
| "UP", | ||
| # pycodestyle (warnings) | ||
| "W", |
There was a problem hiding this comment.
Love the comments here. Thanks!
There was a problem hiding this comment.
no prob! Figured I'd propose this while I'm touching this anyway. I've found comments like this really helpful for organizing this configuration, especially when it gets big like this: https://github.com/rapidsai/cudf/blob/0b32f55b1ed38507437770d21da1e4e1a1c4a17d/pyproject.toml#L30
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least a year ago (I'm not sure when precisely),
ruffbroke up the[ruff]table inpyproject.tomlin favor of storing configuration in several more focused tables, like[tool.ruff.lint]. Context: https://github.com/rapidsai/rapids-reviser/pull/51/files#r1755430166This proposes the following:
pre-commit autoupdate