Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noarch: python #32

Closed

Conversation

jakirkham
Copy link
Member

As this is become a proper Python package, convert it to noarch: python instead of noarch: generic.

As this is become a proper Python package, convert it to `noarch:
python` instead of `noarch: generic`.
@jakirkham jakirkham requested review from vyasr and a team as code owners March 7, 2024 19:36
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did it become a proper Python package?

@jakirkham
Copy link
Member Author

If we are enabling patching: #27

Though if you would prefer to add this change to your PR, that would be ok with me

@jakirkham
Copy link
Member Author

In any event this already depends on Python as Dask does

@pentschev
Copy link
Member

@vyasr
Copy link
Contributor

vyasr commented Mar 7, 2024

The noarch: python change is already in #27:

Right that's why I was confused, #27 is what adds Python code and it already makes this change.

In any event this already depends on Python as Dask does

That's fair, but that's not really how you would typically handle this, right? A package should specify based on its own contents (which as of this PR is still generic and not Python-specific). If its dependencies are more constrained then that will be handled by the package manager's dependency resolver. Of course, in this case the discussion is largely academic since the only purpose of this package is to specify Python package dependencies, but in terms of best practices I would still leave it to those dependencies to specify.

@vyasr
Copy link
Contributor

vyasr commented Mar 13, 2024

Going to close this as redundant to #27

@vyasr vyasr closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants