Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI matrix selectors #28

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#25.
Contributes to rapidsai/build-planning#3.

This project uses a jq filter in its GitHub Actions configuration to select exactly 1 combination of (architecture, Python version, CUDA version) for each of its CI jobs.

This PR proposes removing string literals referencing specific versions, so that the configuration won't have to be updated in the future as RAPIDS changes its supported matrix of Python and CUDA versions.

Credit for this to @bdice / @ajschmidt8 : rapidsai/build-planning#25 (comment). I'm just clicking the buttons 😁

@jameslamb jameslamb marked this pull request as ready for review February 28, 2024 23:53
@jameslamb jameslamb requested review from vyasr and a team as code owners February 28, 2024 23:53
@jakirkham jakirkham requested a review from ajschmidt8 February 29, 2024 00:12
@vyasr
Copy link
Contributor

vyasr commented Feb 29, 2024

I had patched these versions manually in #27 but this solution is definitely better long-term.

@vyasr vyasr merged commit f92bec2 into rapidsai:branch-24.04 Feb 29, 2024
5 checks passed
@jameslamb jameslamb deleted the ci/matrix-filters branch February 29, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants