Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dask and distributed for 24.04 development #25

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

galipremsagar
Copy link
Contributor

This PR unpins dask and distributed for 24.04 development.

@galipremsagar galipremsagar requested a review from vyasr as a code owner February 22, 2024 16:57
@vyasr vyasr merged commit c32b927 into rapidsai:branch-24.04 Feb 22, 2024
3 checks passed
@rjzamora
Copy link
Member

Just a note that we should hold off on releasing this change. It seems likely that we will want to remain pinned to dask-2024.1.1 for 24.04.

@jakirkham
Copy link
Member

Merging added nightlies already. So this is being consumed in RAPIDS

If we want to change this, can I ask you ( @rjzamora ) to writeup recommendations on handling Dask in RAPIDS 24.04?

Possible repos for this issue (though not limited to these locations):

@jakirkham
Copy link
Member

Am now seeing there is a longer discussion happening offline on this topic. Let's continue there for now

That said, it would still be good to have a tracking issue now; where we can fill in more details later

@jakirkham
Copy link
Member

Tracked in issue: #26

galipremsagar pushed a commit that referenced this pull request Feb 29, 2024
- This rolls back the changes in
#25 until we have
a plan to deal with the loud `dask.dataframe` deprecation warning in
`dask>=2024.2.0`
- This adds `dask_expr` as a dependency in preparation for
rapidsai/cudf#14805 (happy to add this in a
follow-up PR if others prefer)
- We may be able to remove the pin for 24.04 if/when
#27 is merged
(fingers crossed). However, the *default* plan is still to keep the
2024.1.1 dask pin in place until 24.06 (see:
#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants